<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Eirik,</p>
<p>I think that method (and its references in some test code
comments) can be removed. Like you note it's a package private
method within the java.util.jar package and I don't see its usage
(other than test code comments) anywhere within the JDK repo. That
@Deprecated annotation on that method seems to have been
introduced as part of <a class="moz-txt-link-freetext" href="https://bugs.openjdk.org/browse/JDK-8066619">https://bugs.openjdk.org/browse/JDK-8066619</a>
(review thread
<a class="moz-txt-link-freetext" href="https://mail.openjdk.org/pipermail/core-libs-dev/2018-December/057030.html">https://mail.openjdk.org/pipermail/core-libs-dev/2018-December/057030.html</a>).
I'm guessing it likely was an oversight to have added that
annotation to an internal method instead of just removing its
usage.</p>
<p>-Jaikiran<br>
</p>
<div class="moz-cite-prefix">On 29/02/24 3:09 am, Eirik Bjørsnøs
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+pBWhuEPdhpp7CawrOnKz=DrniT9A7tUxJbz_KxRVFLVNL1pw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Hi,
<div><br>
</div>
<div>The non-public method java.util.jar.Manifest.make72Safe is
marked <a class="gmail_plusreply" id="plusReplyChip-1"
moz-do-not-send="true">@Deprecated(since="13").</a></div>
<div><br>
</div>
<div>However, the Javadoc comment has a '@deprecation' tag which
presumably should have been `@deprecated`.<br>
</div>
<div><br>
</div>
<div>I first thought of proposing a PR to fix the invalid tag,
but then I noticed that the method is non-public and has no
callers in OpenJDK.</div>
<div><br>
</div>
<div>Not sure I understand why this internal method was marked
deprecated in the first place and not simply removed? Are we
worried about people calling this reflectively?</div>
<div><br>
</div>
<div>What would be the best way to go about this?</div>
<div><br>
</div>
<div>(a) Do nothing</div>
<div>(b) Just fix the tag @deprecation -> <a
class="gmail_plusreply" id="plusReplyChip-4"
moz-do-not-send="true">@deprecated</a></div>
<div>(c) Fix the tag, add forRemoval=true</div>
<div>(d) Just delete the method altogether (it's internal after
all).<br>
<a class="gmail_plusreply" moz-do-not-send="true"><br>
</a></div>
<div>Cheers,</div>
<div>Eirik.</div>
<div><br>
</div>
</div>
</blockquote>
</body>
</html>