<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br id="lineBreakAtBeginningOfMessage"><div><blockquote type="cite"><br><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">I’m not an expert on ZIp files, but from your description it would seem best to create a new field.<div><br></div><div>I agree that the version made by field is also needed.</div><div><br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On May 12, 2024, at 1:56 PM, - <liangchenblue@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr">Hi Alan Snyder,<div>Currently, JDK ZipEntry populates that extraAttributes (proposed to rename to externalFileAttributes in JDK-8321274, PR #16952) only if the high byte of the "version made by" field is 3 (indicating Linux compatibility) and only records the most significant 2 bytes for the copied ZipEntry. Since this is not the "external file attributes" field from the ZIP format, do you still think this field should be exposed, or should we create a new field to properly model the external file attributes? Also worth noting is the support for adjusting the "version made by" field, the "external file attributes" field might be misinterpreted without it.</div><div><br></div><div>P.S. Seems the Skara bridge is not propagating emails to GitHub comments.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 12, 2024 at 2:17 PM Alan Snyder <<a href="mailto:javalists@cbfiddle.com">javalists@cbfiddle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> It might be interesting to explore that in the context of the zip file system provider, less sure about the java.util.zip APIs. <br>
<br>
I was not using the Zip file system. I was processing a Zip file.<br>
<br>
Alan<br>
<br>
<br>
<br>
<br>
<br>
> On May 12, 2024, at 7:32 AM, Chen Liang <<a href="mailto:liach@openjdk.org" target="_blank">liach@openjdk.org</a>> wrote:<br>
> <br>
> On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan <<a href="mailto:duke@openjdk.org" target="_blank">duke@openjdk.org</a>> wrote:<br>
> <br>
>> Add API to access ZipEntry.extraAttributes<br>
> <br>
> Also see #16952, another patch that renames this field, which is planning for an integration soon; this PR will be out-of-date when that one is integrated.<br>
> <br>
> -------------<br>
> <br>
> PR Comment: <a href="https://git.openjdk.org/jdk/pull/19204#issuecomment-2106265843" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk/pull/19204#issuecomment-2106265843</a><br>
> <br>
<br>
</blockquote></div>
</div></blockquote></div><br></div></div></div></blockquote></div><br></body></html>