<div dir="ltr"><br><div>Thanks Lance, I have filed the following enhancement request to track this:</div><div><br></div><div><a href="https://bugs.openjdk.org/browse/JDK-8336843">https://bugs.openjdk.org/browse/JDK-8336843</a><br></div><div><br></div><div>Eirik.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jun 30, 2024 at 2:54 PM Lance Andersen <<a href="mailto:lance.andersen@oracle.com">lance.andersen@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
Hi Eirik,
<div><br>
</div>
<div>The removal of ZipError from ZipFile/ZipFileSystem/ZipFileSystemProvider occurred via <span style="white-space:pre-wrap;background-color:rgb(255,255,255)">8145260 and
</span><span style="white-space:pre-wrap;background-color:rgb(255,255,255)">8037394 for JDK 9</span></div>
<div><span style="white-space:pre-wrap;background-color:rgb(255,255,255)"><br>
</span></div>
<div><span style="white-space:pre-wrap;background-color:rgb(255,255,255)">The test should also be re-written at this point</span></div>
<div><span style="white-space:pre-wrap;background-color:rgb(255,255,255)"><br>
</span></div>
<div><span style="white-space:pre-wrap;background-color:rgb(255,255,255)">Jai or I can make a pass to see if there are any external usages via a corpus search but I tend to doubt it<br id="m_341537614684606033lineBreakAtBeginningOfMessage">
</span>
<div><br>
<blockquote type="cite">
<div>On Jun 30, 2024, at 3:20 AM, Eirik Bjørsnøs <<a href="mailto:eirbjo@gmail.com" target="_blank">eirbjo@gmail.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">Hi!
<div><br>
</div>
<div>The java.util.zip.ZipError class seems unused in OpenJDK. I assume this is legacy from the native ZIP implementation in Java 8.</div>
<div><br>
</div>
<div>This exception class extends InternalError and seems to have been added in Java 6 to help compatibility with existing code catching InternalError (JDK-4615343)</div>
<div><br>
</div>
<div>This change also introduced the TestZipError test, which verified that ZipError was thrown while enumerating a ZIP file which was changed after being opened. The reimplementation of the ZIP implementation to Java (JDK-8145260) updated this test to expect
a ZipException instead of the ZipError. </div>
<div><br>
</div>
<div>Given that this class has now fallen out of use in OpenJDK, should we:</div>
<div><br>
</div>
<div>1: Deprecate it</div>
<div>2: Deprecate it for removal</div>
<div>3: Do nothing, keeping it around has a low cost </div>
<div>4: Something else </div>
<div><br>
</div>
<div>It would also be useful if someone with access to a large code corpus could search for usages of this class so we could assess compatibility concerns of removing it.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Eirik.</div>
</div>
</div>
</blockquote>
</div>
<br>
<div><span><img alt="oracle_sig_logo.gif" src="cid:ii_190cc7178c757a289d01"></span>
<div dir="auto" style="font-family:Helvetica;font-size:18px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;color:rgb(0,0,0)">
<div><br>
<br>
<br>
<br>
<br>
<br>
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037</div>
<div>Oracle Java Engineering <br>
1 Network Drive <br>
Burlington, MA 01803<br>
<a href="mailto:Lance.Andersen@oracle.com" target="_blank">Lance.Andersen@oracle.com</a></div>
</div>
<br style="font-family:Helvetica;font-size:18px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;color:rgb(0,0,0)">
<br style="font-family:Helvetica;font-size:18px;font-style:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;color:rgb(0,0,0)">
</div>
<br>
</div>
</div>
</blockquote></div>