<div dir="ltr"><div dir="ltr">Hi Alexey, all,<br></div><div dir="ltr"><br></div><div>Thank you very much for your reply and the pointers you provided.</div><div><br></div><div>Honestly I don't mind whether the ico file is part of the exe or not. It should just work as expected.<br></div><div>Having said that, we are seeing issues that in some cases it doesn't seem to work (i.e., not showing any icon).</div><div><br></div><div>Let's hope this is an exception<span class="gmail-mw-headline" id="gmail-What-does-the-.F0.9F.A4.9E-.28fingers-crossed.29-emoji-mean.3F">🤞</span>
</div><div><br></div><div>Thanks,</div><div><br></div><div>-- Daniel<br></div><div><br></div><div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 6, 2024 at 7:04 PM Alexey Semenyuk <<a href="mailto:alexey.semenyuk@oracle.com">alexey.semenyuk@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Daniel,<br>
<br>
On Windows, the jpackage embeds icons in app launcher executables and <br>
there is no reason to keep these .ico files in the app image. In [1], it <br>
was reasonably requested not to include app launcher icons in the app <br>
image on Windows, and that was fulfilled.<br>
<br>
[1] <a href="https://bugs.openjdk.org/browse/JDK-8281682" rel="noreferrer" target="_blank">https://bugs.openjdk.org/browse/JDK-8281682</a><br>
<br>
- Alexey<br>
<br>
<br>
On 11/6/2024 4:19 AM, Daniel Peintner wrote:<br>
> Hello,<br>
><br>
> I am not sure if this is the right place to ask, but I hope so.<br>
> If not please let me know where I can report this kind of problem.<br>
><br>
> Recently we changed from JDK 17 to JDK 21 and something seems to have <br>
> changed when running jpackage with --icon option.<br>
><br>
> Produced structure on Windows for<br>
><br>
> # Java 17<br>
> /app<br>
> /runtime<br>
> foo.exe<br>
> foo.ico<br>
><br>
> while for<br>
><br>
> # Java 21 (v 21.0.5)<br>
> /app<br>
> /runtime<br>
> foo.exe<br>
><br>
> As you can see the foo.ico is missing.<br>
> Note: the foo.exe still shows the right icon when looking at it in <br>
> FileExplorer.<br>
><br>
> Anyhow, on some devices the missing ico file is causing issues.<br>
> There is no icon on the program list nor in the taskbar (see attached <br>
> images).<br>
><br>
> Note: On some windows installations it works without issues.<br>
><br>
> Is this a known problem? I tried to browse through <br>
> <a href="https://bugs.openjdk.org" rel="noreferrer" target="_blank">https://bugs.openjdk.org</a> without finding such a bug report.<br>
><br>
> Thanks for any input/advice.<br>
><br>
> -- Daniel<br>
><br>
><br>
<br>
</blockquote></div></div>