<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<br>
<br>
<div class="moz-cite-prefix">On 18/11/2024 21:17, Chen Liang wrote:<br>
</div>
<blockquote type="cite" cite="mid:SJ2PR10MB7669F596D77BE9ACB6C9D3C8A2272@SJ2PR10MB7669.namprd10.prod.outlook.com">
<style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Eirik,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I think it might have been a legacy oversight; note that even
java.util.Arrays was just recently made final.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt;">
<span style="color: rgb(0, 0, 0);">> If Runtime was made
final it seems we could remove the CheckCSMs test.</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I disagree; CheckCSMs test checks for missing CSM annotations
when new caller sensitive methods are added, and to ensure other
reflection changes do not tamper with the caller sensitive
mechanism. The static/final requirements is just one minor
aspect of that test.</div>
<br>
</blockquote>
Right, CheckCSMs is an important test. One of the good things about
the SM removal is that many methods were @CS because of permission
checks are no longer @CS. Better still is some @CS methods in
non-final classes that could be overridden are no longer @CS, hence
the need to update this test as part of several PRs.<br>
<br>
-Alan<br>
</body>
</html>