<div dir="ltr"><div>Thanks for working on this... something of a thankless task :)</div><div><br></div><div>I'm sure you've considered this but I'll ask anyway. Would it make (more or less) sense to try and enforce the policy on the front-end?</div><div><br></div><div>By that I mean adding another checkbox requirement to skara's handling of PR's: "🔲 Change must update copyright dates where applicable"<br></div><div><br></div><div>The check could start out being conservative:</div><div><ul><li>Only applies to files with certain extensions and/or matching some filter list</li><li>Only applies to files containing a recognizable copyright text line</li></ul><div>-Archie<br></div></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, Dec 9, 2024 at 7:06 AM Magnus Ihse Bursie <<a href="mailto:magnus.ihse.bursie@oracle.com">magnus.ihse.bursie@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p>I felt responsibility for the .github files, and wanted to check
if there were more build system files needed updating. So I ran a
more comprehensive script, and discovered a *lot* more files that
needed updating. Like a thousand or so...<br>
</p>
<p>I have opened a series of issues starting at
<a href="https://bugs.openjdk.org/browse/JDK-8345793" target="_blank">https://bugs.openjdk.org/browse/JDK-8345793</a> and going up to
<a href="https://bugs.openjdk.org/browse/JDK-8345805" target="_blank">https://bugs.openjdk.org/browse/JDK-8345805</a> to update these
headers.</p>
<p>I agree, this should be automated. We're starting to slowly get
there, see <a href="https://github.com/openjdk/skara/pull/1702" target="_blank">https://github.com/openjdk/skara/pull/1702</a> for a first
step.</p>
<p>/Magnus<br>
</p>
<div>On 2024-12-03 16:45, Archie Cobbs
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Dumb question...</div>
<div><br>
</div>
<div>It seems like the thing with updating copyright years in
source files could be better automated. At least, couldn't
there be a test that fails if you forget?<br clear="all">
</div>
<div><br>
</div>
<div>FWIW my little updater script says that these files still
need to be updated to 2024:</div>
<div style="margin-left:40px"><span style="font-family:monospace"><br>
</span></div>
<div style="margin-left:40px"><span style="font-family:monospace">.github/actions/config/action.yml<br>
.github/actions/do-build/action.yml<br>
.github/actions/get-bootjdk/action.yml<br>
.github/actions/get-bundles/action.yml<br>
.github/actions/get-msys2/action.yml<br>
.github/scripts/gen-build-failure-report.sh<br>
.github/scripts/gen-test-summary.sh<br>
.github/workflows/build-cross-compile.yml<br>
.github/workflows/test.yml<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/Attributes.java<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/InputSource.java<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/SAXException.java<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/SAXParseException.java<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/XMLReader.java<br>
src/java.base/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java<br>
src/java.base/share/classes/jdk/internal/platform/Metrics.java<br>
test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java<br>
test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java<br>
test/hotspot/jtreg/compiler/whitebox/DeoptimizeFramesTest.java</span></div>
<div><br>
</div>
<div>-Archie<br>
</div>
<div><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature">Archie L. Cobbs<br>
</div>
</div>
</blockquote>
</div>
</blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature">Archie L. Cobbs<br></div>