<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<br>
<br>
<div class="moz-cite-prefix">On 3/3/2025 9:58 PM, Michael Hall
wrote:<br>
</div>
<blockquote type="cite" cite="mid:988B383E-B300-44B8-B1F2-4133719C79A9@gmail.com">
<br id="lineBreakAtBeginningOfMessage">
<div><br>
<blockquote type="cite">
<div>On Mar 3, 2025, at 1:51 PM, Michael Hall
<a class="moz-txt-link-rfc2396E" href="mailto:mik3hall@gmail.com"><mik3hall@gmail.com></a> wrote:</div>
<br class="Apple-interchange-newline">
<div>
<div style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br id="lineBreakAtBeginningOfMessage">
<div><br>
<blockquote type="cite">
<div>On Mar 3, 2025, at 1:37 PM, Alexey Semenyuk
<a class="moz-txt-link-rfc2396E" href="mailto:alexey.semenyuk@oracle.com"><alexey.semenyuk@oracle.com></a> wrote:</div>
<br class="Apple-interchange-newline">
<div>
<div> Hi Michael,<br>
<br>
Thank you for the detailed report! I filed [1]
ticket that, I hope, captures all findings from
your report. Let me know if anything was missed or
misunderstood.<br>
<br>
[1] <a class="moz-txt-link-freetext" href="https://bugs.openjdk.org/browse/JDK-8351073" moz-do-not-send="true">https://bugs.openjdk.org/browse/JDK-8351073</a><br>
<br>
- Alexey<br>
<br>
</div>
</div>
</blockquote>
<br>
</div>
<div>Hello Alexey,</div>
<div><br>
</div>
<div>
<blockquote type="cite"><span style="caret-color: rgb(23, 43, 77); color: rgb(23, 43, 77); font-family: "DejaVu Sans", sans-serif; font-size: 14px; background-color: rgb(255, 255, 255);"> jpackage
should copy them as-is.</span></blockquote>
<br>
</div>
<div>It would be nice if this was the case but I think you
need to be sure changes are made to the Info.plist to
ensure the correct version is indicated in a few
places. </div>
<div><br>
</div>
<div>Apple offers something like plist buddy that could
maybe be used.</div>
<div><br>
</div>
</div>
</div>
</blockquote>
<br>
</div>
<div>Fwiw,</div>
<div><br>
</div>
<div>
<div>(base) mjh@MacBook-Pro-2 ~ % grep -C 1
CFBundleGetInfoString Info.plist</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><string>libjli.dylib</string></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><key>CFBundleGetInfoString</key></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><string>Java
SE 23.0.1+11-39</string></div>
<div>(base) mjh@MacBook-Pro-2 ~ % /usr/libexec/PlistBuddy -c
'set:CFBundleGetInfoString Java SE 25' Info.plist</div>
<div>(base) mjh@MacBook-Pro-2 ~ % /usr/libexec/PlistBuddy -c
'save' Info.plist </div>
<div>Saving...</div>
<div>(base) mjh@MacBook-Pro-2 ~ % grep -C 1
CFBundleGetInfoString Info.plist
</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><string>libjli.dylib</string></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><key>CFBundleGetInfoString</key></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span><string>Java
SE 25</string></div>
</div>
</blockquote>
Good point about `CFBundleGetInfoString`. Maybe jpackage should set
this field with the value of `--description` option. Another
finding!<br>
<br>
As for editing "Info.plist" from the runtime source, if the
directory referenced from `--runtime-image` option is a valid
bundle, i.e. has "Contents/MacOS/libjli.dylib",
"Contents/Info.plist" files, and "Contents/_CodeSignature" elements,
and there are no other options, like `--app-version`, jpackage
should use the supplied directory as-is without editing the existing
"Info.plist" file. Otherwise, jpackage should create "Info.plist"
and make sure the values are consistent, of course.<br>
<br>
- Alexey<br>
</body>
</html>