From akozlov at azul.com Fri Sep 3 08:28:16 2021 From: akozlov at azul.com (Anton Kozlov) Date: Fri, 3 Sep 2021 11:28:16 +0300 Subject: Hello, CRaC! Message-ID: Hi, The CRaC project is being set up, we already have the repo [1]! The only remaining thing is the write access to the wiki, which will be open for each project committer. For me, the next thing to do is to propose the current code from the CRaC prototype as GitHub Pull-Request. This course made things simpler from the legal point of view. We've got invaluable feedback while the project was discussed. New topics (without much details) to investigate are: - Alternative C/R engines support. Cooperation with Firecracker will test the current API proposal and will define future possible enhancements. Another use case is to provide finer control over the CRIU command line, for example to checkpoint without terminating the current instance. - Standard library correctness w.r.t. checkpoint and restore. This work will likely touch security area and the general use of clocks and timeouts. An open topic is how to detect such areas and find particular pieces of implementation to fix. It may be beneficial to track these and other tasks in the bugs database. Looking at the Valhalla Project, project-specific entries are tracked by the Affected and Fix Version fields, e.g. JDK-8251041 [2]. I'll ask can we do the same. Thanks, Anton [1] https://github.com/openjdk/crac [2] https://bugs.openjdk.java.net/browse/JDK-8251041 From akozlov at azul.com Fri Sep 3 08:34:06 2021 From: akozlov at azul.com (Anton Kozlov) Date: Fri, 3 Sep 2021 11:34:06 +0300 Subject: CFV: New CRaC Committer: Christine H. Flood Message-ID: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> I hereby nominate Christine H. Flood to CRaC Committer. Christine is working on a related project [3]. Previously she worked on Shenandoah, and on the parallel collector and G1 before that. Christine will keep an eye on that two projects don't diverge without reasons. Christine should be a member of the CRaC Project from the start. Votes are due by Friday, 17 September 2021, 12:00:00 UTC Only current CRaC Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Thanks, Anton [1] https://openjdk.java.net/census [2] https://openjdk.java.net/projects/#committer-vote [3] https://github.com/chflood/jigawatts From heidinga at redhat.com Fri Sep 3 12:47:52 2021 From: heidinga at redhat.com (Dan Heidinga) Date: Fri, 3 Sep 2021 08:47:52 -0400 Subject: CFV: New CRaC Committer: Christine H. Flood In-Reply-To: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> References: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> Message-ID: Vote: yes --Dan On Fri, Sep 3, 2021 at 4:34 AM Anton Kozlov wrote: > > I hereby nominate Christine H. Flood to CRaC Committer. > > Christine is working on a related project [3]. Previously she worked on > Shenandoah, and on the parallel collector and G1 before that. Christine > will keep an eye on that two projects don't diverge without reasons. > Christine should be a member of the CRaC Project from the start. > > Votes are due by Friday, 17 September 2021, 12:00:00 UTC > > Only current CRaC Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > Anton > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > [3] https://github.com/chflood/jigawatts > From volker.simonis at gmail.com Mon Sep 6 15:55:54 2021 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 6 Sep 2021 17:55:54 +0200 Subject: CFV: New CRaC Committer: Christine H. Flood In-Reply-To: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> References: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> Message-ID: Vote: yes On Fri, Sep 3, 2021 at 10:34 AM Anton Kozlov wrote: > > I hereby nominate Christine H. Flood to CRaC Committer. > > Christine is working on a related project [3]. Previously she worked on > Shenandoah, and on the parallel collector and G1 before that. Christine > will keep an eye on that two projects don't diverge without reasons. > Christine should be a member of the CRaC Project from the start. > > Votes are due by Friday, 17 September 2021, 12:00:00 UTC > > Only current CRaC Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > Anton > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > [3] https://github.com/chflood/jigawatts > From akozlov at openjdk.java.net Fri Sep 10 17:05:41 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Fri, 10 Sep 2021 17:05:41 GMT Subject: [crac] RFR: 8273607: Import crac/jdk Message-ID: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> Import the initial CRaC prototype. The PR targets `crac` branch where it will live, while `master` is automatically synced to `openjdk/master`. The initial implementation is based on jdk-14-ga. After the integration, I'm going to merge the latest promotion build from the `master` branch. Please feel free to leave comments. I'll try to resolve simple issues or will record more complex ones. ------------- Commit messages: - Update for jcheck - Prepare to openjdk/crac - Update copyrights - Handle non-PID 1 subreaper - 8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10 - 8238388: libj2gss/NativeFunc.o "multiple definition" link errors with GCC10 - 8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10 - 8237879: make 4.3 breaks build - Import crac/jdk a60a8255ccd51ff6d6a2663567769a7c59390e90 Changes: https://git.openjdk.java.net/crac/pull/1/files Webrev: https://webrevs.openjdk.java.net/?repo=crac&pr=1&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273607 Stats: 5558 lines in 95 files changed: 5512 ins; 1 del; 45 mod Patch: https://git.openjdk.java.net/crac/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/crac pull/1/head:pull/1 PR: https://git.openjdk.java.net/crac/pull/1 From akozlov at openjdk.java.net Fri Sep 10 17:18:09 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Fri, 10 Sep 2021 17:18:09 GMT Subject: [crac] RFR: 8273607: Import crac/jdk [v2] In-Reply-To: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> References: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> Message-ID: <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> > Import the initial CRaC prototype. The PR targets `crac` branch where it will live, while `master` is automatically synced to `openjdk/master`. The initial implementation is based on jdk-14-ga. After the integration, I'm going to merge the latest promotion build from the `master` branch. > > Please feel free to leave comments. I'll try to resolve simple issues or will record more complex ones. Anton Kozlov has updated the pull request incrementally with four additional commits since the last revision: - Revert "8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10" This reverts commit 5753cadf8e449cd61ec100bac0e30b44f2c4bea4. - Revert "8238388: libj2gss/NativeFunc.o "multiple definition" link errors with GCC10" This reverts commit 7dcc6fa5620824ac72aabea54fb8459c552d093c. - Revert "8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10" This reverts commit d9688feedc73c68f4023df37332f093bd3b3143a. - Revert "8237879: make 4.3 breaks build" This reverts commit 24b5e247c747fa08275861cadf1898d6458c3860. ------------- Changes: - all: https://git.openjdk.java.net/crac/pull/1/files - new: https://git.openjdk.java.net/crac/pull/1/files/d5c4d836..a5f81699 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=crac&pr=1&range=01 - incr: https://webrevs.openjdk.java.net/?repo=crac&pr=1&range=00-01 Stats: 30 lines in 7 files changed: 0 ins; 12 del; 18 mod Patch: https://git.openjdk.java.net/crac/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/crac pull/1/head:pull/1 PR: https://git.openjdk.java.net/crac/pull/1 From simonis at openjdk.java.net Mon Sep 13 14:50:40 2021 From: simonis at openjdk.java.net (Volker Simonis) Date: Mon, 13 Sep 2021 14:50:40 GMT Subject: [crac] RFR: 8273607: Import crac/jdk [v2] In-Reply-To: <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> References: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> Message-ID: <7vqOQVYcGhKtqmWUFzdx1oQNdggRIZ5TR7SHbYE3htc=.ae1e64f8-99f9-4416-9e41-85a0f8ba55a5@github.com> On Fri, 10 Sep 2021 17:18:09 GMT, Anton Kozlov wrote: >> Import the initial CRaC prototype. The PR targets `crac` branch where it will live, while `master` is automatically synced to `openjdk/master`. The initial implementation is based on jdk-14-ga. After the integration, I'm going to merge the latest promotion build from the `master` branch. >> >> Please feel free to leave comments. I'll try to resolve simple issues or will record more complex ones. > > Anton Kozlov has updated the pull request incrementally with four additional commits since the last revision: > > - Revert "8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10" > > This reverts commit 5753cadf8e449cd61ec100bac0e30b44f2c4bea4. > - Revert "8238388: libj2gss/NativeFunc.o "multiple definition" link errors with GCC10" > > This reverts commit 7dcc6fa5620824ac72aabea54fb8459c552d093c. > - Revert "8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10" > > This reverts commit d9688feedc73c68f4023df37332f093bd3b3143a. > - Revert "8237879: make 4.3 breaks build" > > This reverts commit 24b5e247c747fa08275861cadf1898d6458c3860. If you want to first import the initial CRaC version which is based on `jdk-14-ga` into the `crac` branch in this repository which is itself based on the same `jdk14-ga` tag it is unclear to me why you have to do additional changes (like the four reverts) before integrating. I thought you first want to import CRaC "as-is" and then merge the `crac` branch with the latest master? ------------- PR: https://git.openjdk.java.net/crac/pull/1 From akozlov at openjdk.java.net Mon Sep 13 15:07:42 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Mon, 13 Sep 2021 15:07:42 GMT Subject: [crac] RFR: 8273607: Import crac/jdk [v2] In-Reply-To: <7vqOQVYcGhKtqmWUFzdx1oQNdggRIZ5TR7SHbYE3htc=.ae1e64f8-99f9-4416-9e41-85a0f8ba55a5@github.com> References: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> <7vqOQVYcGhKtqmWUFzdx1oQNdggRIZ5TR7SHbYE3htc=.ae1e64f8-99f9-4416-9e41-85a0f8ba55a5@github.com> Message-ID: <5nUwMO0qsBk-zFagbVS-t7g9HUmrAUnQhUlIWxYJmIM=.ba1757b9-e1c1-408f-a7ed-b079b24fac4f@github.com> On Mon, 13 Sep 2021 14:47:35 GMT, Volker Simonis wrote: > I thought you first want to import CRaC "as-is" and then merge the crac branch with the latest master? Yes, this code is based on jdk14. I did few backports to build the code on newer systems, but then I realized I'd better keep them off. Then I reverted them. So the cumulative change of this PR is the initial implementation from crac/jdk repository, jcheck, Github Action, copyrights/licenses updates . I'm going to integrate this as a single commit, so extra commits and reverts won't pollute the git history. ------------- PR: https://git.openjdk.java.net/crac/pull/1 From simonis at openjdk.java.net Tue Sep 14 13:52:51 2021 From: simonis at openjdk.java.net (Volker Simonis) Date: Tue, 14 Sep 2021 13:52:51 GMT Subject: [crac] RFR: 8273607: Import crac/jdk [v2] In-Reply-To: <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> References: <3xvG20QK5GRmTQs0_C7mh5-slh1SlNZ4ys7F44tNz9U=.953a0677-813e-4b27-a8ec-8aef01a10f43@github.com> <-VCv3J-kMHMS6wKaBwkn5QSHmdCjTjMaI1rmrBT66MQ=.6487907d-8211-4a2a-a051-8c4f9e24f877@github.com> Message-ID: On Fri, 10 Sep 2021 17:18:09 GMT, Anton Kozlov wrote: >> Import the initial CRaC prototype. The PR targets `crac` branch where it will live, while `master` is automatically synced to `openjdk/master`. The initial implementation is based on jdk-14-ga. After the integration, I'm going to merge the latest promotion build from the `master` branch. >> >> Please feel free to leave comments. I'll try to resolve simple issues or will record more complex ones. > > Anton Kozlov has updated the pull request incrementally with four additional commits since the last revision: > > - Revert "8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10" > > This reverts commit 5753cadf8e449cd61ec100bac0e30b44f2c4bea4. > - Revert "8238388: libj2gss/NativeFunc.o "multiple definition" link errors with GCC10" > > This reverts commit 7dcc6fa5620824ac72aabea54fb8459c552d093c. > - Revert "8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10" > > This reverts commit d9688feedc73c68f4023df37332f093bd3b3143a. > - Revert "8237879: make 4.3 breaks build" > > This reverts commit 24b5e247c747fa08275861cadf1898d6458c3860. Looks good to me. Fine for me. ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.java.net/crac/pull/1 From heidinga at redhat.com Wed Sep 15 16:03:38 2021 From: heidinga at redhat.com (Dan Heidinga) Date: Wed, 15 Sep 2021 12:03:38 -0400 Subject: CFV: New CRaC Committer: Christine H. Flood In-Reply-To: References: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> Message-ID: I think everyone eligible to vote has done so at this point. What's the next step here to get Christine added as a committer? --Dan On Mon, Sep 6, 2021 at 11:56 AM Volker Simonis wrote: > > Vote: yes > > On Fri, Sep 3, 2021 at 10:34 AM Anton Kozlov wrote: > > > > I hereby nominate Christine H. Flood to CRaC Committer. > > > > Christine is working on a related project [3]. Previously she worked on > > Shenandoah, and on the parallel collector and G1 before that. Christine > > will keep an eye on that two projects don't diverge without reasons. > > Christine should be a member of the CRaC Project from the start. > > > > Votes are due by Friday, 17 September 2021, 12:00:00 UTC > > > > Only current CRaC Committers [1] are eligible to vote on this > > nomination. Votes must be cast in the open by replying to this > > mailing list. > > > > For Lazy Consensus voting instructions, see [2]. > > > > Thanks, > > Anton > > > > [1] https://openjdk.java.net/census > > [2] https://openjdk.java.net/projects/#committer-vote > > [3] https://github.com/chflood/jigawatts > > > From akozlov at azul.com Wed Sep 15 17:59:42 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 15 Sep 2021 20:59:42 +0300 Subject: CFV: New CRaC Committer: Christine H. Flood In-Reply-To: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> References: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> Message-ID: <5813a91c-7ec1-97c8-c1e9-8fad61376a41@azul.com> Vote: yes On 9/3/21 11:34 AM, Anton Kozlov wrote: > I hereby nominate Christine H. Flood to CRaC Committer. > > Christine is working on a related project [3]. Previously she worked on > Shenandoah, and on the parallel collector and G1 before that.? Christine > will keep an eye on that two projects don't diverge without reasons. > Christine should be a member of the CRaC Project from the start. > > Votes are due by Friday, 17 September 2021, 12:00:00 UTC > > Only current CRaC Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > Anton > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > [3] https://github.com/chflood/jigawatts > From akozlov at azul.com Wed Sep 15 18:06:47 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 15 Sep 2021 21:06:47 +0300 Subject: CFV: New CRaC Committer: Christine H. Flood In-Reply-To: References: <2e552089-ab21-abc5-ec08-ba6ab4cd820f@azul.com> Message-ID: <74095ac5-32b4-28e3-9909-56fdbcb698b9@azul.com> On 9/15/21 7:03 PM, Dan Heidinga wrote: > I think everyone eligible to vote has done so at this point. What's > the next step here to get Christine added as a committer? Thanks for reminding me. although the voting time is not over, I think we can really close the vote. I'll verify this with the registrar and will announce the result. Thanks, Anton From duke at openjdk.java.net Wed Sep 15 18:13:41 2021 From: duke at openjdk.java.net (duke) Date: Wed, 15 Sep 2021 18:13:41 GMT Subject: git: openjdk/crac: crac: jcheck: Allow peer-review Message-ID: Changeset: c53fb564 Author: Anton Kozlov Date: 2021-09-15 21:08:45 +0000 URL: https://git.openjdk.java.net/crac/commit/c53fb564145ae10db2b878de6b10ee2c83d81501 jcheck: Allow peer-review ! .jcheck/conf From akozlov at azul.com Wed Sep 15 18:44:13 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 15 Sep 2021 21:44:13 +0300 Subject: Hello, CRaC! In-Reply-To: References: Message-ID: <390d5f9a-f3f2-6049-8604-a6550b5f9de5@azul.com> On 9/3/21 11:28 AM, Anton Kozlov wrote: > The next thing to do is to propose the current code from the CRaC > prototype as GitHub Pull-Request. Now we have the code in the crac branch [1], thanks to Volker for testing the workflow. So I drafted contributing guidelines on the wiki [2]. Feedback and tryouts are welcome. Thanks, Anton [1] https://github.com/openjdk/crac/tree/crac [2] https://wiki.openjdk.java.net/display/crac/Main From akozlov at azul.com Wed Sep 15 20:13:40 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 15 Sep 2021 23:13:40 +0300 Subject: Result: New CRaC Committer: Christine H. Flood Message-ID: <6249ad07-18e3-41f3-3223-2ee30a6782dd@azul.com> Voting for Christine H. Flood [1] is now closed. Yes: 3 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Anton Kozlov [1] https://mail.openjdk.java.net/pipermail/crac-dev/2021-September/000001.html From akozlov at azul.com Wed Sep 29 12:13:40 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 29 Sep 2021 15:13:40 +0300 Subject: [crac] Early-Access Builds Message-ID: <7b8044d3-4a89-796e-0f63-9608b978595f@azul.com> Hi, I've added a link to the CRaC early access builds to the wiki [1]: https://github.com/CRaC/openjdk-builds/releases This is a prerequisite for the "Testing" subsection under the "Contributing". I linked [2], but something more focused on the OpenJDK testing would suit better. Thanks, Anton [1]: https://wiki.openjdk.java.net/display/crac [2]: https://github.com/CRaC/docs/blob/master/STEP-BY-STEP.md From akozlov at azul.com Wed Sep 29 13:02:31 2021 From: akozlov at azul.com (Anton Kozlov) Date: Wed, 29 Sep 2021 16:02:31 +0300 Subject: CFV: New CRaC Committer: Gil Tene Message-ID: <80ed0ed9-80e6-cd6a-53e2-cface1412cb0@azul.com> I hereby nominate Gil Tene to CRaC Committer. Gil is the CTO of Azul who is actively participating in all design discussions and decisions for the CRaC project. Gil is the one who has brought an idea of coordinating Checkpoint/Restore with Java Runtime. He contributed a lot of insights during discussions of approaches, details of the implementation, and the analysis of the prototype. Gil is going to contribute to the further development of the OpenJDK CRaC project helping to solve complex problems. Votes are due by Wednesday, 13 October 2021, 14:00:00 GMT. Only current CRaC Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Thanks, Anton [1] https://openjdk.java.net/census [2] https://openjdk.java.net/projects/#committer-vote From heidinga at redhat.com Mon Sep 27 14:47:17 2021 From: heidinga at redhat.com (heidinga at redhat.com) Date: Mon, 27 Sep 2021 14:47:17 GMT Subject: [crac] RFR: Merge jdk-17+35 In-Reply-To: References: Message-ID: <84nhk-Rzs6wKFU0AmiKmFCJwRcBfOxeMecGv1BHmfk0=.58ba6f50-1401-4f15-ab1c-18d9b453a132@github.com> On Fri, 24 Sep 2021 18:50:24 GMT, Anton Kozlov wrote: >> Merge tag jdk-17+35. All CRaC-specific tests pass, although there are only few of them. > > I'm going to tag the merge as `crac-17+1`. That is, first build of JDK17 with CRaC. @AntonKozlov What's the preferred process on this kind of change? I'm new to managing merges of the JDK mainline into project specific repos so not yet clear on what level of review something like this would need. > All CRaC-specific tests pass, although there are only few of them. As this is a merge of mainline (well, 17) I'm OK with giving this the +1 assuming that's the process we typically follow for this? Do projects typically follow the releases or the mainline development? Still learning the norms here :) ------------- PR: https://git.openjdk.java.net/crac/pull/2 From akozlov at azul.com Mon Sep 27 16:02:22 2021 From: akozlov at azul.com (akozlov at azul.com) Date: Mon, 27 Sep 2021 16:02:22 GMT Subject: [crac] RFR: Merge jdk-17+35 In-Reply-To: <84nhk-Rzs6wKFU0AmiKmFCJwRcBfOxeMecGv1BHmfk0=.58ba6f50-1401-4f15-ab1c-18d9b453a132@github.com> References: <84nhk-Rzs6wKFU0AmiKmFCJwRcBfOxeMecGv1BHmfk0=.58ba6f50-1401-4f15-ab1c-18d9b453a132@github.com> Message-ID: On Mon, 27 Sep 2021 14:44:54 GMT, Dan Heidinga wrote: > What's the preferred process on this kind of change? I'm new to managing merges of the JDK mainline into project specific repos so not yet clear on what level of review something like this would need. I'm not sure also :) But I wanted to provide a heads up at least for the bump of the major version. Merges of minor versions probably are OK without review, if we'll do them often. > > All CRaC-specific tests pass, although there are only few of them. > > As this is a merge of mainline (well, 17) I'm OK with giving this the +1 assuming that's the process we typically follow for this? Yeah, I think this would be useful, a simple acknowledgment from other member(s). > Do projects typically follow the releases or the mainline development? Still learning the norms here :) We are free to choose something most suitable for us. I think having both makes sense: following mainline development for fast resolution of the problems with merges and a stable release for users to try. However, it is an additional burden in maintenance. Having 17, the merge of the early pre-18 state should be simple, the opposite looks harder. So for following 17 looks useful but simple enough. We can extend this any time we'd want, I think. ------------- PR: https://git.openjdk.java.net/crac/pull/2 From heidinga at redhat.com Mon Sep 27 19:09:10 2021 From: heidinga at redhat.com (heidinga at redhat.com) Date: Mon, 27 Sep 2021 19:09:10 GMT Subject: [crac] RFR: Merge jdk-17+35 In-Reply-To: References: Message-ID: On Fri, 24 Sep 2021 16:21:48 GMT, Anton Kozlov wrote: > Merge tag jdk-17+35. All CRaC-specific tests pass, although there are only few of them. Seems like a reasonable starting point. ------------- PR: https://git.openjdk.java.net/crac/pull/2 From akozlov at azul.com Tue Sep 28 10:51:35 2021 From: akozlov at azul.com (akozlov at azul.com) Date: Tue, 28 Sep 2021 10:51:35 GMT Subject: [crac] RFR: Merge jdk-17+35 [v2] In-Reply-To: References: Message-ID: > Merge tag jdk-17+35. All CRaC-specific tests pass, although there are only few of them. Anton Kozlov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/crac/pull/2/files - new: https://git.openjdk.java.net/crac/pull/2/files/9e54b029..9e54b029 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=crac&pr=2&range=01 - incr: https://webrevs.openjdk.java.net/?repo=crac&pr=2&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/crac/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/crac pull/2/head:pull/2 PR: https://git.openjdk.java.net/crac/pull/2 From akozlov at azul.com Tue Sep 28 10:51:36 2021 From: akozlov at azul.com (akozlov at azul.com) Date: Tue, 28 Sep 2021 10:51:36 GMT Subject: [crac] RFR: Merge jdk-17+35 In-Reply-To: References: Message-ID: <4l7Agj2VhWgXwQ5D5qyWzHtGggME_d77HeMJhOED6No=.ec0f42e0-4b0c-4271-b671-863f66fa1e58@github.com> On Mon, 27 Sep 2021 19:05:07 GMT, Dan Heidinga wrote: > github repeatedly fails to load the "files" tab with a "This page is taking too long to load." so I'm unable to actually review the PR in the UI. Anyone know of a workaround for this? Funny enough, it's actually impossible to provide review (e.g. after checking out changes locally) without github attempt to show the diff. > Otherwise, please consider this reviewed. OK, thanks! ------------- PR: https://git.openjdk.java.net/crac/pull/2 From akozlov at azul.com Tue Sep 28 10:51:36 2021 From: akozlov at azul.com (akozlov at azul.com) Date: Tue, 28 Sep 2021 10:51:36 GMT Subject: [crac] Withdrawn: Merge jdk-17+35 In-Reply-To: References: Message-ID: <3w6QRncHBV_o1nnYS_N1g41-1NGULGEKqmhqIBFwJtY=.aee0a099-e1ed-4810-84ec-f44e7086f423@github.com> On Fri, 24 Sep 2021 16:21:48 GMT, Anton Kozlov wrote: > Merge tag jdk-17+35. All CRaC-specific tests pass, although there are only few of them. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/crac/pull/2