[crac] RFR: Fix NPE on ZipFile$Source access [v2]

Anton Kozlov akozlov at openjdk.java.net
Fri Apr 8 19:14:12 UTC 2022


On Fri, 8 Apr 2022 13:35:59 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'zip-fix' of https://github.com/AntonKozlov/crac into zip-fix
>>  - Fix NPE on ZipFile$Source access
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1797:
> 
>> 1795:                 FileDescriptor fd = null;
>> 1796:                 try {
>> 1797:                     fd = f.getFD();
> 
> Could you pls check, may be, zfile.getFD() instead of f.getFD() ?

You're a hawkeye! I had an amended version all the time locally, and tested that. The difference is indeed in this line. Thanks! Fixed.

-------------

PR: https://git.openjdk.java.net/crac/pull/17


More information about the crac-dev mailing list