[crac] RFR: Reseed secure random on checkpoint restore [v3]

Alexey Bakhtin abakhtin at openjdk.java.net
Tue Jan 18 15:42:40 UTC 2022


On Thu, 13 Jan 2022 16:32:55 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Set JDKResource priorities for SecureRandom
>>  - Merge branch 'crac' of https://github.com/openjdk/crac into SecureRandom
>>  - Add separate JDKResorce for seeder
>>  - Reseed secure random on checkpoint restore
>
> src/java.base/share/classes/sun/security/provider/SecureRandom.java line 256:
> 
>> 254:             SeedGenerator.generateSeed(b);
>> 255:             seeder.engineSetSeed(b);
>> 256:             jdk.internal.crac.Core.getJDKContext().register(new SeederHolder());
> 
> Resources are weakly referenced [1], so this SeederHolder object will likely be collected very soon
> 
> [1] https://github.com/openjdk/crac/blob/43aba3d502832a5a3d2e9712558f62e0cf93dbbb/src/java.base/share/classes/jdk/crac/package-info.java#L74

Thank you. Fixed in new version

-------------

PR: https://git.openjdk.java.net/crac/pull/7


More information about the crac-dev mailing list