[crac] RFR: Support extra criu flags from the environment [v2]

Volker Simonis simonis at openjdk.org
Thu Jun 30 17:12:04 UTC 2022

On Thu, 30 Jun 2022 06:43:52 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>>   Drop surplus arguments from CRAC_CRIU_OPTS and issue a warning
> src/java.base/unix/native/criuengine/criuengine.c line 116:
>> 114:         }
>> 115:         *arg++ = NULL;
>> 116:         assert(ARRAY_SIZE(args) >= (size_t)(arg - args));
> I'm not sure if we are compiling with asserts. Could you turn this and another assert below into a runtime check and explicit failure if arguments do not fit?

You're right. We compile product builds with `-DNDEBUG`. I've reworked the code to drop surplus arguments from `CRAC_CRIU_OPTS` and issue a warning if this was necessary.


PR: https://git.openjdk.org/crac/pull/26

More information about the crac-dev mailing list