[crac] RFR: Provide arguments for restore [v3]
Anton Kozlov
akozlov at openjdk.java.net
Sat Mar 5 09:17:28 UTC 2022
On Wed, 2 Mar 2022 18:50:01 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename to newArguments, add javax.crac mirror
>
> src/hotspot/os/linux/os_linux.cpp line 5862:
>
>> 5860: fprintf(stderr, "write shm truncated");
>> 5861: }
>> 5862: close(shmfd);
>
> Should this close the file? Given the data didn't write correctly I think we should `shm_unlink` the shared mapping so it gets released.
Nice catch, thanks!
-------------
PR: https://git.openjdk.java.net/crac/pull/16
More information about the crac-dev
mailing list