[crac] RFR: Allow users to pass new properties on restore [v8]

[Ashutosh Mehra]

On Tue, 24 May 2022 15:47:17 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Ashutosh Mehra has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Parse arguments for restore separately and perform restore early
>>   
>>   Also
>>   - removed "modifiable" marker for system properties
>>   - pass all system properties to the process being restored
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/os/linux/os_linux.cpp line 285:
> 
>> 283: };
>> 284: 
>> 285: class VM_CracRestoreParameters : public CHeapObj<mtInternal> {
> 
> `VM_` prefix look like this class inherits VM_Op, but it's not. Removing the prefix would be fine.

Done

> src/hotspot/os/linux/os_linux.cpp line 308:
> 
>> 306:     _nprops(0),
>> 307:     _properties(new (ResourceObj::C_HEAP, mtInternal) GrowableArray<const char *>(0, mtInternal)),
>> 308:     _args(args)
> 
> This constructor apparently is not used, remove?

This constructor is used in `os::Linux::restore`

-------------

PR: https://git.openjdk.java.net/crac/pull/21