[crac] RFR: Report checkpoint processing to jcmd [v31]
Anton Kozlov
akozlov at openjdk.org
Fri Nov 4 09:32:12 UTC 2022
On Thu, 3 Nov 2022 15:52:26 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:
>> pass output stream from diagnosticCommand.cpp through java code into os_linux.cpp::VM_crac::doit()
>
> Ilarion Nakonechnyy has updated the pull request incrementally with one additional commit since the last revision:
>
> Style fix
Marked as reviewed by akozlov (Lead).
src/hotspot/share/services/diagnosticCommand.cpp line 1062:
> 1060: tty->print("%s", output_buf.as_string());
> 1061: } else {
> 1062: output()->print("%s", output_buf.as_string());
Nit-picking: it looks like you may avoid the intermediate buffer by choosing a stream in advance
outputStream stream = ... ? output() : tty
stream->println("An exception during a checkpoint operation:");
stream->println("%s", out);
-------------
PR: https://git.openjdk.org/crac/pull/10
More information about the crac-dev
mailing list