[crac] RFR: Force closing a "redirected to the file" standard io descriptor [v2]

Ilarion Nakonechnyy inakonechnyy at openjdk.org
Fri Nov 11 14:38:33 UTC 2022


> CRIU restore fail after Checkpoint stdout to file.
> Redirecting a stdout to the pipeline doesn't break the restore. 
> 
> A proposed approach forces the close of stdout, stdin, and stderr file descriptors if they are redirected to the files, on checkpoint resources verification.

Ilarion Nakonechnyy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Different approach, if std descriptors bind to a file,
   replace is with binded to pseudo terminal
 - Merge branch 'crac' into stdout-restore
 - jchek corrections
 - corrections
 - corrections
 - Close stdin, stderr, stdout fd before checkpoint
    if they are redirected to a file.

-------------

Changes:
  - all: https://git.openjdk.org/crac/pull/24/files
  - new: https://git.openjdk.org/crac/pull/24/files/6cf8cb99..c3347ad3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=crac&pr=24&range=01
 - incr: https://webrevs.openjdk.org/?repo=crac&pr=24&range=00-01

  Stats: 1290 lines in 30 files changed: 961 ins; 184 del; 145 mod
  Patch: https://git.openjdk.org/crac/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/crac pull/24/head:pull/24

PR: https://git.openjdk.org/crac/pull/24


More information about the crac-dev mailing list