[crac] RFR: Assume module jars persistent [v2]

Anton Kozlov akozlov at openjdk.org
Wed Nov 30 15:04:53 UTC 2022


On Tue, 29 Nov 2022 18:55:01 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move everything to the separate class
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferences.java line 247:
> 
>> 245:             this.jf = newJarFile(path);
>> 246:             this.uri = uri;
>> 247:             this.resource = new JDKResource() {
> 
> Would it be cleaner to implement this JDKResource subclass as a named class in `JarFileCRaCSupport` and wrap this logic so we have something like:
> 
> this.resource = JarFileCRaCSupport.wrapAndRegisterJarFile(this.jf);
> 
> 
> It centralizes more of the Jar file support in one place....

Indeed, I've created ClassLoaderJarFile for that purpose. Moving the whole class to be used by ModuleReferences.

-------------

PR: https://git.openjdk.org/crac/pull/35


More information about the crac-dev mailing list