[crac] RFR: Assume module jars persistent [v2]

Anton Kozlov akozlov at openjdk.org
Wed Nov 30 17:40:38 UTC 2022

On Wed, 30 Nov 2022 15:32:27 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>   Move everything to the separate class
> src/java.base/share/classes/jdk/internal/util/jar/PersistentJarFile.java line 56:
>> 54:                 zipBeforeCheckpoint.setAccessible(true);
>> 55:                 return null;
>> 56:             }});
> Something to think about that doesn't need to be addressed now:
> We may want to lazily cache the accessible reflect Method in a static field to avoid looking it up for each PersistentJarFile.  The value of doing that depends somewhat on how many jars we expect here and how much we care about time spent in checkpoint hooks.

Oh, you're right. Not sure when it will be an another chance to improve, so better be done now :) This implementation with reflection predated the SharedSecrets, which cleaner, safer, faster -- so I just used that.


PR: https://git.openjdk.org/crac/pull/35

More information about the crac-dev mailing list