[crac] RFR: Environment vars propagation into restored process [v3]
Anton Kozlov
akozlov at openjdk.org
Tue Oct 18 07:36:48 UTC 2022
On Mon, 3 Oct 2022 08:21:56 GMT, Roman Marchenko <duke at openjdk.org> wrote:
>> This PR provides functionality to propagate actual environment variables to a restored process, as well as the test for this functionality.
>>
>> Env propagation is done in few steps:
>> - Store the actual environment before restoring
>> - After restoring, replace the restored `environ` with a new one.
>> - On `afterRestore` event, propagate the new environment into a restored process via `ProcessEnvironment`.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixing review comments
Thank you to all participants of this interesting discussion. I see the points in different aspects, in Roman's implementation of the mechanism and in Dan's concerns about policy how it should be used, and how to debug possible issues. I propose to move with smaller steps and implement missing features and polish the policy in the subsequent PR(s), on top of the simpler implementation.
-------------
PR: https://git.openjdk.org/crac/pull/30
More information about the crac-dev
mailing list