[crac] RFR: Environment vars propagation into restored process [v3]

Roman Marchenko duke at openjdk.org
Thu Oct 20 06:49:45 UTC 2022


On Mon, 3 Oct 2022 08:21:56 GMT, Roman Marchenko <duke at openjdk.org> wrote:

>> This PR provides functionality to propagate actual environment variables to a restored process, as well as the test for this functionality.
>> 
>> Env propagation is done in few steps:
>> - Store the actual environment before restoring
>> - After restoring, replace the restored `environ` with a new one.
>> - On `afterRestore` event, propagate the new environment into a restored process via `ProcessEnvironment`.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing review comments

Thank you all for your comments! As far as I understand, we've got some different opinions about further directions, so we need to work on principles to make the approaches consistent. 
Does the document creation stop us from merging this PR now? If no, I'd merge it.

-------------

PR: https://git.openjdk.org/crac/pull/30


More information about the crac-dev mailing list