[crac] Integrated: Harden criuengine cppath reading

Anton Kozlov akozlov at openjdk.org
Thu Apr 13 13:04:10 UTC 2023


On Fri, 24 Mar 2023 19:00:38 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

> On some older OSes I see a few `fgets error` coming from criuengine restore function. They are intermittent and hard to debug. After replacing libc fopen/fgets invocations with open/read, the problem went away. I'm still not completely sure why the problem with libc file functions exists but I suspect that EINTR is not correctly handled there, or the fact we store a sequence in characters without `\0` or `\n` in the file we read. So I propose using the lower-level interface to read the file.

This pull request has now been integrated.

Changeset: f91de330
Author:    Anton Kozlov <akozlov at openjdk.org>
URL:       https://git.openjdk.org/crac/commit/f91de3309aefbd8ff6acdbefe4e80528d0e04d57
Stats:     19 lines in 1 file changed: 11 ins; 2 del; 6 mod

Harden criuengine cppath reading

-------------

PR: https://git.openjdk.org/crac/pull/56


More information about the crac-dev mailing list