[crac] RFR: Print better diagnostics for spawning CRIU [v4]

Jan Kratochvil jkratochvil at openjdk.org
Thu Aug 10 07:28:29 UTC 2023

> It was always a mystery why it does not work this time as there are no error messages printed.
> Still may system call errors are currently not reported but those errors at least do not happen commonly.
> In fact `os::exec_child_process_and_wait` should be more verbose but that is already a part of OpenJDK so I did not modify it.
> It would be much easier if `criuengine.c` was in C++. I was considering to switch it but then I wrote it already in C.
> I understand this code will become obsolete after planned integration of CRIU into JVM but it may not yet be soon enough.

Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:

  Reformat error messages
   - Radim Vansa


  - all: https://git.openjdk.org/crac/pull/97/files
  - new: https://git.openjdk.org/crac/pull/97/files/74ea1e2c..ad440f18

 - full: https://webrevs.openjdk.org/?repo=crac&pr=97&range=03
 - incr: https://webrevs.openjdk.org/?repo=crac&pr=97&range=02-03

  Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/crac/pull/97.diff
  Fetch: git fetch https://git.openjdk.org/crac.git pull/97/head:pull/97

PR: https://git.openjdk.org/crac/pull/97

More information about the crac-dev mailing list