[crac] RFR: Print better diagnostics for spawning CRIU [v2]

Jan Kratochvil jkratochvil at openjdk.org
Thu Aug 10 12:16:01 UTC 2023


On Thu, 10 Aug 2023 11:49:57 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> The code was more simple that way and it was straightforward to replace it with C++17 `std::filesystem::path` after [OpenJDK makes the switch to C++17](https://bugs.openjdk.org/browse/JDK-8310260).
>
> The interface is fine, the implementation just could be more straightforward and efficient.
> 
> The link you're refering has Resolution: Rejected.

It had been changed, is it OK now? https://github.com/openjdk/crac/pull/97/commits/74ea1e2c0171646b3bd4d2f6e4c8dd5eaecfae44
The C++17 switch has been currently rejected but IMO it must happen one day.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/97#discussion_r1290017959


More information about the crac-dev mailing list