[crac] Integrated: Print better diagnostics for spawning CRIU

Jan Kratochvil jkratochvil at openjdk.org
Thu Aug 10 14:17:58 UTC 2023


On Mon, 31 Jul 2023 03:42:11 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> It was always a mystery why it does not work this time as there are no error messages printed.
> Still may system call errors are currently not reported but those errors at least do not happen commonly.
> In fact `os::exec_child_process_and_wait` should be more verbose but that is already a part of OpenJDK so I did not modify it.
> It would be much easier if `criuengine.c` was in C++. I was considering to switch it but then I wrote it already in C.
> I understand this code will become obsolete after planned integration of CRIU into JVM but it may not yet be soon enough.

This pull request has now been integrated.

Changeset: d3ea8456
Author:    Jan Kratochvil <jkratochvil at openjdk.org>
Committer: Anton Kozlov <akozlov at openjdk.org>
URL:       https://git.openjdk.org/crac/commit/d3ea8456815ebd161bbecac8fd8b4810a4c19443
Stats:     71 lines in 2 files changed: 65 ins; 0 del; 6 mod

Print better diagnostics for spawning CRIU

Reviewed-by: akozlov

-------------

PR: https://git.openjdk.org/crac/pull/97


More information about the crac-dev mailing list