[crac] RFR: Keep _features the same after CRaC restore [v2]

Anton Kozlov akozlov at openjdk.org
Wed Aug 16 09:58:40 UTC 2023


On Tue, 15 Aug 2023 09:29:05 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> Extending `_features` may change ABI or existing JIT-compiled code. Unfortunately we cannot use more advanced CPU features after restore, we need to stick to the same features of CPU used to make the checkpoint file.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Do not modify global variables in crac_restore()
>  - Merge branch 'crac' into crac-keepfeatures
>  - Keep _features the same after CRaC restore

LGTM, and thank you for the SUPPORTS() cleanup

-------------

Marked as reviewed by akozlov (Lead).

PR Review: https://git.openjdk.org/crac/pull/103#pullrequestreview-1580233312


More information about the crac-dev mailing list