[crac] RFR: Wait until G1 GC has finished before creating a snapshot. [v6]

Jan Kratochvil jkratochvil at openjdk.org
Mon Aug 21 18:13:58 UTC 2023

On Mon, 7 Aug 2023 12:35:22 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> I read now I should contact https://mail.openjdk.org/pipermail/hotspot-gc-dev/ , thanks for the advice.
> AFAICS HeapRegionManager::uncommit_inactive_regions is synchronized by Uncommit_lock.
> https://github.com/openjdk/crac/blob/fbeaadb611f355b0616ebd25d86b9a7ced83276a/src/hotspot/share/gc/g1/heapRegionManager.cpp#L311

I somehow missed this lock. OK, I agree it is safe.


PR Review Comment: https://git.openjdk.org/crac/pull/93#discussion_r1300477950

More information about the crac-dev mailing list