[crac] RFR: Stop JMX RMI before checkpoint & restart after restore

Radim Vansa rvansa at openjdk.org
Wed Dec 6 11:16:20 UTC 2023


On Wed, 6 Dec 2023 11:10:31 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> When JMX is exposed over RMI through system properties `com.sun.management.jmxremote.*` the checkpoint would fail; this PR closes all sockets and reopens listening sockets after restore.

src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPTransport.java line 293:

> 291:                     "server socket: " + server + ", exportCount: " + exportCount);
> 292:         }
> 293:         if (exportCount == 0) {

In my opinion, this is the most risky change in this PR; I am not sure what was the motivation for not closing the server socket listening on the random port.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/146#discussion_r1417117701


More information about the crac-dev mailing list