[crac] RFR: RestoreEnvironmentTest refactoring

Dan Heidinga heidinga at openjdk.org
Mon Feb 6 06:01:18 UTC 2023


On Tue, 31 Jan 2023 07:23:11 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> The test was extended with the example to illustrate the scenario when an user don't like to propagate some of environment variables into a restored process (see `RESTORE_ENVIRONMENT_TEST_VAR2` in `RestoreEnvironmentTest.sh`). See the initial discussion here #30

I'll quote my response from the (closed) PR #30:
> The current CRaC approach still allows overriding env vars, which is something Java (and developers, and library developers) doesn't expect to happen so they haven't written their code to be aware these values can change. Changing existing env vars on restore will just lead to inconsistent systems.

Full response in https://github.com/openjdk/crac/pull/30#issuecomment-1412545649

-------------

PR: https://git.openjdk.org/crac/pull/42


More information about the crac-dev mailing list