[crac] RFR: CRaC may exit before image dump is completed

[Dan Heidinga]

On Tue, 21 Feb 2023 13:50:23 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> When running CRaC with docker, java may exit before CRIU is finished dumpring because CRIU kills the original java process, and then docker immediately exits.
> 
> It could be reproduced with a simple Java test:
> 
> import jdk.crac.Core;
> public class Test {
>     public static void main(String args[]) throws Exception {
>         Core.checkpointRestore();
>         System.out.println("finish");
>     }
> }
> 
> and run with docker:
> `docker <docker_options> $JAVA_HOME/java -XX:CRaCCheckpointTo=./cr Test.java`
> 
> After the command above finishes, `cr/cppath` is absent in the case of failure. Or/and it will fail on restore:
> `docker <docker_options> $JAVA_HOME/java -XX:CRaCRestoreFrom=./cr`
> 
> This change fixes the issue by forkin'g the main process in case of PID=1 (pid=1 means it was run with docker), and waiting for children processes are finished. This makes us sure that CRIU finalized the dump, if any. At the same time, there is no conflict with PIDs on restore, since the process being restored has PID not equal to 1, if restoring with the command above..

src/java.base/share/native/launcher/main.c line 236:

> 234: 
> 235:     if (is_checkpoint && 1 == getpid()) {
> 236:         if (0 < fork()) {

Not an expert in this area, but don't we also need to handle `SIGTERM` appropriately by forwarding it to the child process if the forking receives it?

-------------

PR: https://git.openjdk.org/crac/pull/46