[crac] RFR: Close extraneous file descriptors [v2]

Anton Kozlov akozlov at openjdk.org
Fri Feb 24 18:45:44 UTC 2023


On Thu, 23 Feb 2023 07:37:24 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 2103:
>> 
>>> 2101:       "unavailable")                                                        \
>>> 2102:                                                                             \
>>> 2103:   product(ccstr, CRaCIgnoredFileDescriptors, NULL, "Comma-separated list "  \
>> 
>> Should not `0,1,2` be the default option then? So it will be also possible to overwrite this default.
>
> I didn't use `0,1,2` as if you want to ignore FD 42 you would have to write `0,1,2,42` rather than just 42. Starting with standard FDs closed is extremely non-standard, and in that case we should do something about `System.out` as well to be consistent.

Agree, the current implementation makes sense.

-------------

PR: https://git.openjdk.org/crac/pull/45


More information about the crac-dev mailing list