[crac] RFR: Handle open file descriptors with configurable policies [v9]

[Radim Vansa]

On Fri, 30 Jun 2023 13:09:23 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cosmetic fixes (imports)
>
> src/java.base/unix/classes/sun/nio/ch/FileDispatcherImpl.java line 212:
> 
>> 210:         // the FD value set breaks JDKSocketResource (we don't want the extra
>> 211:         // test if the FD resource has been marked).
>> 212:         fdAccess.closeNoCleanup(fd);
> 
> Should not it be just `close()`ed? `unregisterCleanup` looks to be idempotent. And I remember you had a mail thread regarding this close/close0, could you remind the link?

Do you mean this thread? https://mail.openjdk.org/pipermail/nio-dev/2023-January/013075.html

Well this was meant to change the behaviour as little as possible. All the ways the FD can be closed looks pretty spaghetti to me; I can give the regular close a go and see what breaks...

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/69#discussion_r1251670806