[crac] RFR: Win/Mac build for CRaC [v11]
Roman Marchenko
rmarchenko at openjdk.org
Thu Jul 6 12:46:32 UTC 2023
On Wed, 5 Jul 2023 16:41:13 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Roman Marchenko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> Disabled ContextOrderTest for win because ClaimedFD doesn't support win handles
>
> make/modules/java.base/Launcher.gmk line 134:
>
>> 132: $(eval $(call SetupJdkExecutable, BUILD_PAUSEENGINE, \
>> 133: NAME := pauseengine, \
>> 134: SRC := $(TOPDIR)/src/$(MODULE)/windows/native/pauseengine, \
>
> It looks like this line is the only reason to duplicate pauseengine build rule. Can this be changed to
>
> SRC := $(TOPDIR)/src/$(MODULE)/$(OPENJDK_TARGET_OS_TYPE)/native/pauseengine, \
>
> And unified with the Unix rule?
>
> Same with `pauseengine` rule below.
Actually the reason is OUTPUT_DIR.
For unixes it is $(SUPPORT_OUTPUTDIR)/**modules_libs**/$(MODULE)
For windows it is $(SUPPORT_OUTPUTDIR)/**modules_cmds**/$(MODULE)
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1254383699
More information about the crac-dev
mailing list