[crac] RFR: Win/Mac build for CRaC [v16]

Anton Kozlov akozlov at openjdk.org
Mon Jul 10 07:49:29 UTC 2023


On Mon, 10 Jul 2023 07:19:47 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> - OS-dependent CRaC functionality moved to `crac_<os>`.* files.
>> - Data structures moved to `crac_structs.hpp`
>> - Added necessary cross-platform functionality
>> - Some local calls are put under `#ifdef` checks
>> - GHA: Enabled Crac tests run in windows build
>> - GHA: macOs build is disabled until CRaC moves to newer JDK version.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor change

LGTM, thank you!

-------------

Marked as reviewed by akozlov (Lead).

PR Review: https://git.openjdk.org/crac/pull/82#pullrequestreview-1521471976


More information about the crac-dev mailing list