[crac] RFR: macOS build fixes [v2]

Roman Marchenko rmarchenko at openjdk.org
Mon Jul 24 13:33:27 UTC 2023


On Mon, 24 Jul 2023 12:58:36 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing review comments
>
> src/java.base/unix/native/libjava/FileDescriptor_md.c line 147:
> 
>> 145: }
>> 146: 
>> 147: #ifdef __APPLE__
> 
> Should this apply only on Macs, or would that attribute be useful for other platforms as well?

Agree

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/92#discussion_r1272260085


More information about the crac-dev mailing list