[crac] RFR: RFC: -XX:CPUFeatures=0xnumber for CPU migration [v38]

[Jan Kratochvil]

On Thu, 27 Jul 2023 13:05:21 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do not remove the altstack fix which got committed as a part of:
>>     https://github.com/openjdk/crac/commit/4b0dc2dc9722945579c9772b335a44fa79f1729f
>>   It was originally submitted as:
>>     https://github.com/openjdk/crac/pull/37
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 942:
> 
>> 940:       excessive_CPU |= CPU_SSE2;
>> 941:     }
>> 942:     if ((_features & CPU_FXSR) &&
> 
> My compiler started to complain on this, and it looks valid:
> 
> 
> src/hotspot/cpu/x86/vm_version_x86.cpp: In static member function 'static void VM_Version::glibc_not_using(uint64_t, uint64_t)':
> src/hotspot/cpu/x86/vm_version_x86.cpp:1118:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>    if ((_features & CPU_CMOV) &&
>    ^~
> src/hotspot/cpu/x86/vm_version_x86.cpp:1129:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
>      if ((_features & CPU_FXSR) &&
>      ^~
> cc1plus: all warnings being treated as errors
> 
> 
> @jankratochvil it indeed looks like a missing bracket, is it a bug?

Yes, sorry, #94.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/41#discussion_r1276384725