[crac] RFR: Active cleanup by CleanerImpl on checkpoint [v3]

Radim Vansa duke at openjdk.org
Wed Jun 7 06:20:25 UTC 2023

On Tue, 6 Jun 2023 16:16:19 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>   Don't block the cleaner thread during C/R at all.
> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 160:
>> 158:                             wait();
>> 159:                         }
>> 160:                         cleanupComplete = false;
> AFIAU this synchronizes with beforeCheckpoint to verfiy cleanupComplete==true is noticied. An alternative would be to drop this sync, releasing cleaner sooner, and then just reset cleanupComplete in beforeCheckpoint(). But this is not a big deal.

This has a point, the waiting is not needed in here. I've moved the synchronization from previous version rather mindlessly.


PR Review Comment: https://git.openjdk.org/crac/pull/73#discussion_r1220916493

More information about the crac-dev mailing list