[crac] RFR: Use special class for exception aggregates [v5]

Anton Kozlov akozlov at openjdk.org
Wed Jun 7 11:24:25 UTC 2023

On Wed, 7 Jun 2023 10:53:32 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> Extracted non-essential changes from other PR.
> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>  - Merge branch 'crac' into code_cleanup
>  - Remove the .Combined, always use the main exception as aggregate
>  - Merge branch 'crac' into code_cleanup
>  - Handle .Combined in Core
>  - Use Combiner exception class for aggregate-only exceptions
>  - Minor code cleanup and improvements

Few minor comments

src/java.base/share/classes/jdk/crac/Core.java line 147:

> 145:                 if (messages.length == 0) {
> 146:                     checkpointException.addSuppressed(new RuntimeException("Native checkpoint failed"));
> 147:                 }

codes.length == messages.length, and they are used to communicate native descriptors problems (handled in translateJVMExceptions). So a problem should be reported based on the retCode below, if that is not reported already (?)

src/java.base/share/classes/jdk/crac/impl/AbstractContextImpl.java line 1:

Empty file

src/java.base/share/classes/jdk/crac/impl/PriorityContext.java line 1:

Empty file


PR Review: https://git.openjdk.org/crac/pull/64#pullrequestreview-1467353319
PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1221390006
PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1221395950
PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1221395710

More information about the crac-dev mailing list