[crac] RFR: Support passing extra options in CREngine

Radim Vansa duke at openjdk.org
Fri Jun 9 08:53:09 UTC 2023

On Thu, 8 Jun 2023 18:42:13 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> In addition to `-XX:CREngine=program` this adds support to `-XX:CREngine=program,key=value,anotherkey` that translates into invoking `program --key value --anotherkey`.
>> This generic parameters support is utilized in `criuengine` that accepts `--verbosity` and `--log-file` options and relays them to `criu`.
> src/java.base/unix/native/criuengine/criuengine.c line 105:
>> 103:             "-D", imagedir,
>> 104:             "--shell-job",
>> 105:             "-v4", "-o", "dump4.log", // -D without -W makes criu cd to image dir for logs
> The dump4.log is a great debugging aid for checkpoint and restore failures, please keep it.
> I think a part of the reason for this change is to provide some logging to the console. I think the reporting should be implemented separately https://github.com/openjdk/crac/pull/64#discussion_r1221827050

By default the file is still used, see lines 113 - 116. The args just support overriding those.


PR Review Comment: https://git.openjdk.org/crac/pull/63#discussion_r1224029871

More information about the crac-dev mailing list