[crac] RFR: Make CheckpointException/RestoreException aggregate-only [v8]

Radim Vansa duke at openjdk.org
Fri Jun 9 15:31:14 UTC 2023

On Fri, 9 Jun 2023 13:48:32 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>   Update javadoc, make final
> src/java.base/share/classes/jdk/crac/Core.java line 89:
>> 87:         if (codes.length == 0) {
>> 88:             exception.addSuppressed(new RuntimeException("Native checkpoint failed."));
>> 89:         }
> Turns out this fires on checkpoint dry runs. Suppose a Resource has thrown an exception, we go to JVM just to check no native FD is open. When everything is OK on native side (codes and messages are empty), this exception is thrown, although no native checkpoint is attempted.

Shouldn't a dry-run return `JVM_CHECKPOINT_OK`? Which test is that, `DryRunTest` works for me?


PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1224455064

More information about the crac-dev mailing list