[crac] RFR: RFC: -XX:CPUFeatures=0xnumber for CPU migration [v30]

Jan Kratochvil jkratochvil at openjdk.org
Sun Jun 11 13:59:15 UTC 2023

On Thu, 8 Jun 2023 13:30:40 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

> I meet with the same error as reported by GHA

I have fixed that. I am mostly ignoring GHA as there are too many false positives. The problem was I was using only _release_ builds for some time where it did not reproduce.

> Replacing vm_exit_during_initialization() with fatal() at least provides the hs_err and the stack trace.

I did not want a stack trace. Those are normal error messages, stack trace would be rather confusing. Please request it again if you really mean it.

> I'm not 100% sure fatal() is correct in that state, so I propose a vararg macro/function that expands to fatal(...), which can easily be replaced with something different.

I have found there exists **err_msg()** so I have used it. That **jio_snprintf()**+**vm_exit_during_initialization()** are also used at some hotspot places which is why I used that originally like a copycat. Addressed now by: https://github.com/openjdk/crac/pull/41/commits/9d2298ba9d89c1a2f7e5143153c8e280da6dccec


PR Comment: https://git.openjdk.org/crac/pull/41#issuecomment-1586176111

More information about the crac-dev mailing list