[crac] RFR: Make CheckpointException/RestoreException aggregate-only [v8]

Radim Vansa duke at openjdk.org
Mon Jun 12 09:37:16 UTC 2023

On Fri, 9 Jun 2023 17:44:04 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Shouldn't a dry-run return `JVM_CHECKPOINT_OK`? Which test is that, `DryRunTest` works for me?
> The test does not cover this case: when a Resource throws something and we go to dry run JVM inspection, but the inspection does not find anything. 
> Turns out, ContextOrderTest fails bacuse the same reason.
> JVM dry-run now always returns CHECKPOINT_ERROR by implementation. But in general the the code should depend on the inspection result: OK if no offending descriptors found, ERROR (better to be FD_ERROR) when there are open file descriptors.

Fixed in https://github.com/openjdk/crac/pull/80


PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1226371508

More information about the crac-dev mailing list