[crac] RFR: Fixing VMOptionsTest.java

Roman Marchenko rmarchenko at openjdk.org
Wed Jun 14 10:52:25 UTC 2023

On Tue, 13 Jun 2023 14:59:46 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> @rvansa Could you review please?
> Hi @wkia , the PR looks correct, but I wonder if we need to complicate things if the NMT default is not the same in different builds. I've picked this simply as a random specimen of the non-manageable opts (with string args); could you just use something else, e.g. `OnOutOfMemoryError`, or if you want to go with non-empty default there's `MetaspaceReclaimPolicy`?

Hi @rvansa,
If my understanding correct regarding NMT, the test checks that non-manageable options cannot be set on restore. If so, there is no need to focus on _default_ values. Ok, I will make appropriate changes.


PR Comment: https://git.openjdk.org/crac/pull/81#issuecomment-1590957046

More information about the crac-dev mailing list