[crac] RFR: Refactoring - extracted crac files

Roman Marchenko rmarchenko at openjdk.org
Fri Jun 16 11:49:30 UTC 2023

On Fri, 16 Jun 2023 11:35:22 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> CRaC-related functionality is moved to `crac*.hpp/cpp` files, and now it is in `crac` class instead of `os`.
> src/hotspot/share/runtime/arguments.cpp line 3235:
>> 3234: 
>> 3235:   if (CRaCCheckpointTo && !crac::Linux::prepare_checkpoint()) {
> Does it really make sense to have `crac::Linux` instead of just `crac::`? The most of the operations are not related to Linux, so it may be even better to start abstracting them from Linux in this PR, to avoid another similar renaming in the same place.

Ok, let's get rid of crac::linux now.


PR Review Comment: https://git.openjdk.org/crac/pull/84#discussion_r1232141645

More information about the crac-dev mailing list