[crac] RFR: Handle open file descriptors with configurable policies [v6]

Radim Vansa rvansa at openjdk.org
Fri Jun 16 14:12:30 UTC 2023

On Fri, 16 Jun 2023 12:50:55 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>   cleanup
> src/java.base/share/classes/java/lang/ProcessBuilder.java line 715:
>> 713:         final FileDescriptor fd;
>> 714:         @SuppressWarnings("unused")
>> 715:         final JDKFileResource resource = new JDKFileResource(this) {
> Should really a pipe be handled as a File?

I initially removed pipes from OpenFilePolicies and then returned that back in. Java handles pipes (like standard IO) using FileInputStream/FileOutputStream anyway, `Process.PipeInputStream`  extends `FileInputStream` etc. From the streaming API access to named pipes is the same as accessing a file.


PR Review Comment: https://git.openjdk.org/crac/pull/69#discussion_r1232306034

More information about the crac-dev mailing list