[crac] RFR: Refactoring - extracted crac files [v2]

Anton Kozlov akozlov at openjdk.org
Mon Jun 19 11:17:40 UTC 2023

On Fri, 16 Jun 2023 13:20:39 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> CRaC-related functionality is moved to `crac*.hpp/cpp` files, and now it is in `crac` class instead of `os`.
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>  - Merge branch 'crac' into crac-extract
>  - Getting rid of crac::Linux
>  - Removing trailing spaces
>  - Refactoring - extracted crac* files

I would propose "Extract crac functionality into OS-agnostic files" as the title and eventual commit message, or something like that.

LGTM in the rest! Thank you.


Marked as reviewed by akozlov (Lead).

PR Review: https://git.openjdk.org/crac/pull/84#pullrequestreview-1485989811

More information about the crac-dev mailing list