[crac] RFR: Wake up all TIMED_WAITING threads after restore [v2]

Radim Vansa rvansa at openjdk.org
Tue Jun 20 08:34:46 UTC 2023

> This is a fix for an issue found by @jankratochvil when testing #53: Threads that enter sleep or timed parking use absolute monotonic time for pthread_cond_timedwait(). When the monotonic time changes during C/R we need to wake all threads to readjust the timeout to the new absolute time.
> This introduces effectively a spurious wakeup; this is permitted for all the uses of pthread_cond_timedwait. Implementation either handles that transparently or propagates the wakeup to Java.
> This commit does not handle timed waiting in non-Java threads other than WatcherThread.

Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:

  Use Threads::java_threads_do, check spurious timeouts


  - all: https://git.openjdk.org/crac/pull/85/files
  - new: https://git.openjdk.org/crac/pull/85/files/4bf707b6..bae1c541

 - full: https://webrevs.openjdk.org/?repo=crac&pr=85&range=01
 - incr: https://webrevs.openjdk.org/?repo=crac&pr=85&range=00-01

  Stats: 81 lines in 3 files changed: 40 ins; 22 del; 19 mod
  Patch: https://git.openjdk.org/crac/pull/85.diff
  Fetch: git fetch https://git.openjdk.org/crac.git pull/85/head:pull/85

PR: https://git.openjdk.org/crac/pull/85

More information about the crac-dev mailing list