[crac] RFR: PID adjustment on checkpoint [v3]
Roman Marchenko
rmarchenko at openjdk.org
Wed Jun 21 13:53:35 UTC 2023
On Wed, 21 Jun 2023 12:55:05 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Disabling the test for non-linux platforms
>
> src/java.base/share/native/launcher/main.c line 339:
>
>> 337: spin_last_pid(crac_min_pid);
>> 338: }
>> 339: }
>
> I think we may drop get_last_pid completely. E.g. it should be enough to
>
> if (!set_last_pid(crac_min_pid - 1)) { // set_last_pid reports status
> spin_last_pid(...)
> }
The last PID may be greater than the current PID, so there might be the last PID satisfying CRaC requirements. If so, there is no need to set the last PID at all in such case.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237037065
More information about the crac-dev
mailing list