[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Wed Jun 21 13:58:40 UTC 2023

On Wed, 21 Jun 2023 13:03:44 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>   Disabling the test for non-linux platforms
> src/java.base/share/native/launcher/main.c line 201:
>> 199: 
>> 200: static void spin_last_pid(int pid) {
>> 201:     for (pid_t child = fork(); child < (pid_t)pid; child = fork()) {
> Although this part is not peformance critical, in my previous experiments, fork() was considerably more expensive compared to some minimalistic thread or vfork(). The best I found was `syscall(SYS_clone, SIGCHLD, NULL, NULL, 0)`. Could you check can that be made not too ugly? Maybe pthread_create?

ok, I will check


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237046166

More information about the crac-dev mailing list