[crac] RFR: PID adjustment on checkpoint [v3]

Radim Vansa rvansa at openjdk.org
Wed Jun 21 14:24:36 UTC 2023

On Wed, 21 Jun 2023 06:17:39 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> On restore, there might be PID value conflicts because of small PID values, if it was checkpoint'ed in a container. Therefore, when checkpointing in a container, we need to move PID value for new processes to a particular value to avoid conflicts on restore.
>> See https://github.com/CRaC/example-lambda/blob/master/checkpoint.cmd.sh#L8 for example.
>> This PR contains implemented functionality similar to the example above, making this work out of the box. By default, if checkpointing, PID value for new processes starts from 128. 
>> To set a custom value, `CRAC_MIN_PID` environment variable should be used. 
>> Min `CRAC_MIN_PID` value is 1, max `CRAC_MIN_PID` is not implemented currently.
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>   Disabling the test for non-linux platforms

I wonder, given your other work, what will be the path to support other platforms? If that's going to be just `#ifdef LINUX` you could already guard platform-specific code with that.


PR Comment: https://git.openjdk.org/crac/pull/86#issuecomment-1600931750

More information about the crac-dev mailing list