[crac] RFR: PID adjustment on checkpoint [v8]

[Roman Marchenko]

On Tue, 27 Jun 2023 11:59:54 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fixing review comments
>>  - Revert "Now CracMinPid option must be set explicitly to adjust PID"
>>    
>>    This reverts commit b3d66800d6ea441fb86498fdbb229400747eb44f.
>
> src/java.base/share/native/launcher/main.c line 195:
> 
>> 193:     }
>> 194:     const char *last_pid_filename = "/proc/sys/kernel/ns_last_pid";
>> 195:     const int last_pid_file = open(last_pid_filename, O_WRONLY|O_CREAT|O_TRUNC, 0666);
> 
> O_CREAT looks redundant.
> And this file requires special capability for the process. Shouldn't we address this in the doc?

Agreed.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1243914093