[crac] RFR: PID adjustment on checkpoint [v8]
    Roman Marchenko 
    rmarchenko at openjdk.org
       
    Tue Jun 27 15:27:02 UTC 2023
    
    
  
On Tue, 27 Jun 2023 12:02:55 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fixing review comments
>>  - Revert "Now CracMinPid option must be set explicitly to adjust PID"
>>    
>>    This reverts commit b3d66800d6ea441fb86498fdbb229400747eb44f.
>
> src/java.base/share/native/launcher/main.c line 200:
> 
>> 198:     }
>> 199:     int res = 0;
>> 200:     if (0 > write(last_pid_file, buf, len)) {
> 
> I'd compare with len, just to handle all  "write" return values
Done
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1243932966
    
    
More information about the crac-dev
mailing list